Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do temporary/example deploys for PRs #28

Open
huonw opened this issue Dec 31, 2023 · 1 comment
Open

Do temporary/example deploys for PRs #28

huonw opened this issue Dec 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@huonw
Copy link
Contributor

huonw commented Dec 31, 2023 •
edited
Loading

It'd be great if PRs to this repo deployed the static site somewhere it could be viewed, so that a reviewer can validate.

See #4 (comment) for initial discussions.

(It'd also be interesting to have temporary deploys on the Pants repo, e.g. make a change to the in-repo docs there and be able to view it in some form, but that's likely best solved in that repo.)
@huonw huonw added the enhancement New feature or request label Dec 31, 2023
@huonw huonw mentioned this issue Dec 31, 2023
Closed
This was referenced Feb 14, 2024
Open
Merged
huonw added a commit that referenced this issue Feb 19, 2024
@huonw
Upload build from PR CI for easier previewing (#150)
92d5ce8 
This has PR CI upload the resulting static site output, once the build
finishes.

This is a stop gap for
#28 that's seems like
it's better than nothing: to preview a PR, click through to the build
summary, download the artifact and take a look. This saves a reviewer
from needing to check-out the branch and build it, just do a (100MB)
download instead.
@huonw
Copy link
Contributor Author

huonw commented Feb 19, 2024

If/when we do this, it might make sense to revert #150.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huonw