Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to release notes in 2.23.0 blog post. #297

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Nov 24, 2024

The old link pointed to a nonexistent page.

Also fix links in the 2.22.0 post that 2.23.0 was
copy-pasta'd from. Those links weren't broken,
but they led to a redirection page, so might as
well point them to the target location.

The old link pointed to a nonexistent page.

Also fix links in the 2.22.0 post that 2.23.0 was
copy-pasta'd from. Those links weren't broken,
but they led to a redirection page, so might as
well point them to the target location.
@benjyw benjyw requested review from huonw and cburroughs November 24, 2024 20:51
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the <(...)> bits.

@@ -16,7 +16,7 @@

{/* truncate */}

We are pleased to announce Pants [2.22.0](<(https://github.com/pantsbuild/pants/tree/2.22.x/src/python/pants/notes/2.22.x.md)>), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.22.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.22/docs/getting-started).
We are pleased to announce Pants [2.22.0](<(https://github.com/pantsbuild/pants/tree/2.22.x/docs/notes/2.22.x.md)>), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.22.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.22/docs/getting-started).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the wrong path, It looks like the first link here has some extra syntax that breaks the link:

Suggested change
We are pleased to announce Pants [2.22.0](<(https://github.com/pantsbuild/pants/tree/2.22.x/docs/notes/2.22.x.md)>), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.22.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.22/docs/getting-started).
We are pleased to announce Pants [2.22.0](https://github.com/pantsbuild/pants/tree/2.22.x/docs/notes/2.22.x.md), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.22.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.22/docs/getting-started).

@@ -16,7 +16,7 @@

{/* truncate */}

We are pleased to announce Pants [2.23.0](<(https://github.com/pantsbuild/pants/tree/2.23.x/src/python/pants/notes/2.23.x.md)>), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.23.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.23/docs/getting-started).
We are pleased to announce Pants [2.23.0](<(https://github.com/pantsbuild/pants/blob/2.23.x/docs/notes/2.23.x.md)>), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.23.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.23/docs/getting-started).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Suggestion matching the 2.22.0 change, for convenience)

Suggested change
We are pleased to announce Pants [2.23.0](<(https://github.com/pantsbuild/pants/blob/2.23.x/docs/notes/2.23.x.md)>), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.23.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.23/docs/getting-started).
We are pleased to announce Pants [2.23.0](https://github.com/pantsbuild/pants/blob/2.23.x/docs/notes/2.23.x.md), the latest release of [Pantsbuild, the scalable and ergonomic build system](https://www.pantsbuild.org/). To update, set `pants_version = "2.23.0"` in your `pants.toml`. If you're not using Pants yet, [get started now](https://www.pantsbuild.org/2.23/docs/getting-started).

@benjyw benjyw merged commit 8e8ebf3 into pantsbuild:main Nov 24, 2024
1 check passed
@benjyw benjyw deleted the fix_release_blog_post_links branch November 24, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants