Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog post for in-workspace execution #298

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Dec 3, 2024

Add blog post for the in-workspace execution support in Pants v2.23.0.

@tdyas tdyas requested review from benjyw and huonw December 3, 2024 04:00
@tdyas
Copy link
Contributor Author

tdyas commented Dec 3, 2024

pantsbuild/example-workspace-execution#2 which adds Docker support to the example repository needs to land first.

Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Thanks.

@benjyw
Copy link
Contributor

benjyw commented Dec 3, 2024

What about a splash image? I think all posts have one

@tdyas
Copy link
Contributor Author

tdyas commented Dec 3, 2024

What about a splash image? I think all posts have one

I don't recall having done a splash image for the user survey blog post.

I'm not really a fan of having to choose stock art with some tangential relation to the "workspace" or "sandbox" theme of the blog post, mainly because my aesthetic sense is just okay.

@tdyas
Copy link
Contributor Author

tdyas commented Dec 3, 2024

I added a splash image from Unsplash of a generic office "workspace"

@tdyas tdyas force-pushed the tdyas/blog/in-workspace-environments branch from ac22f45 to dde97b3 Compare December 3, 2024 18:02
@tdyas
Copy link
Contributor Author

tdyas commented Dec 3, 2024

Made more edits.

@benjyw
Copy link
Contributor

benjyw commented Dec 3, 2024

I added a splash image from Unsplash of a generic office "workspace"

Cool. Can you post a screenshot of the render?

@tdyas
Copy link
Contributor Author

tdyas commented Dec 3, 2024

Rendered:

Screenshot 2024-12-03 at 15-22-43 In-Workspace Execution in Pants v2 23 x Pantsbuild

@tdyas tdyas merged commit 10ac488 into main Dec 5, 2024
1 check passed
@tdyas tdyas deleted the tdyas/blog/in-workspace-environments branch December 5, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants