Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill support for python 2.6. #408

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Aug 31, 2017

Closes #405

Copy link
Contributor

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jsirois
Copy link
Member Author

jsirois commented Aug 31, 2017

@kwlzn PTAL, added new code and tests to finally resolve the unicode/bytes issues across 2.7,3.x,pypy.

Copy link
Contributor

@kwlzn kwlzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Also introduce a `to_unicode` complement to `to_bytes` to aid in
removal of `ByteIO`/`StringIO` re-directs.

Closes pex-tool#405
@jsirois jsirois merged commit e7ff4be into pex-tool:master Sep 1, 2017
@jsirois jsirois deleted the jsirois/py26/kill branch September 1, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants