Leverage pex.common.open_zip.
#409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use in one spot in the `pex.testing` module where we weren't before.
|
Discovered working too many open files issue under pypy in #408 CI job. |
kwlzn
approved these changes
Sep 1, 2017
|
No clues. I just noticed the beta Trust banner on the failing pypy shard and tried pinning back to Precise. I'll try a spin against each tomorrow with |
|
Turns out the newer Travis Trusty image has a 30000 open file limit and Precise (the former default) 524288, so this seems to explain the new pypy failures. I did an audit of pex code file leaks and only turned up one instance of zip files in tests - fixed here, and 1 instance in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use in one spot in the
pex.testingmodule where we weren'tbefore.