Fix CI: Use a tmpdir SCIE_BASE to force bootstrapping, incorporate Python path into cache key #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This comment was marked as resolved.
This comment was marked as resolved.
benjyw
approved these changes
Apr 3, 2024
huonw
changed the title
|
I've added another fix beyond the original change to set |
benjyw
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with CI:
SCIE_BASE) by setting that to a fresh temp dir.test_pants_source_modetest, because the venv from the restored cache had an symlink to/opt/hostedtoolcache/Python/3.9.18/x64/bin/python(NB version 3.9.18), but the runners have updated to 3.9.19. Fixes CI failures when GitHub Actions upgrades its python patch version #270.