Test Ubuntu Xenial #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think you're supposed to default to this being false, and only turn on if there's a compelling reason.
stuhood
approved these changes
Mar 12, 2019
Eric-Arellano
added a commit
to Eric-Arellano/setup
that referenced
this pull request
Mar 12, 2019
commit e8cf735 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:36:16 2019 -0700 Trusty Py34 is from system, not pyenv commit 1f7d236 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:30:08 2019 -0700 OSX requires language: general commit 4941956 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:23:28 2019 -0700 Move constant to top of file Think this is the style used in most Python projects and ours. commit c478ecb Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:19:29 2019 -0700 Set Pyenv for Trusty commit 30aab56 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:16:58 2019 -0700 Try pyenv approach Path wrangling didn't work. commit 9b9e6be Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:12:11 2019 -0700 Global python entry -> build matrix See if moving back to osx_setup and linux_setup works. commit 0dc87dc Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:09:18 2019 -0700 Maybe fix Trusty using Py3.4 commit aaab4bf Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:05:50 2019 -0700 Test if OSX comes pre-installed with Python? commit 96cb6ac Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:02:44 2019 -0700 Remove unneeded anchors from OSX shards Turns out Precise comes installed with 3.6 when requested! So we only need Pyenv for OSX, not Linux. commit 4a312a4 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 09:01:31 2019 -0700 Try to debug Trusty image using Py3.4 commit d511d99 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:48:28 2019 -0700 Remove stray whitespace commit 126ae2f Merge: cd28677 4aee51a Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:47:56 2019 -0700 Merge branch 'gh-pages' of github.com:pantsbuild/setup into ci-py commit 4aee51a Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:46:38 2019 -0700 Test Ubuntu Xenial (pantsbuild#31) Travis added Xenial back in November. See https://blog.travis-ci.com/2018-11-08-xenial-release. Adding this test results in better coverage. commit cd28677 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:36:55 2019 -0700 Add prefix to script. Oops commit 4afcdcf Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:24:43 2019 -0700 Add comment explaining why we rewrite pants.ini like this commit ef5bf71 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:22:55 2019 -0700 Tweak ci.py formatting commit 599ae46 Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 08:19:38 2019 -0700 Try to install Py36 on each shard Also modernize .travis.yml to use all the cool goodies we've learned in Pants's CI like anchors and the brew addon package! commit 717271f Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 07:50:10 2019 -0700 Remove PythonVersion and fix --pants-version unspecified --pants-version unspecified would fail because of a bad config, that the contrib module would refer to pants_version even though that line was deleted. commit d1f9f0f Author: Eric Arellano <ericarellano@me.com> Date: Tue Mar 12 07:40:38 2019 -0700 Add ci.py to CI to allow parameterizing pants_version and python_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis added Xenial back in November. See https://blog.travis-ci.com/2018-11-08-xenial-release.
Adding this test results in better coverage.