Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gutil dependency #142

Closed
wants to merge 3 commits into from
Closed

Conversation

idleberg
Copy link

@idleberg idleberg commented Jan 2, 2018

As advised by the Gulp maintainers, this PR removes the dependency on gulp-util. However, since there are no type declarations for two of the replacement modules, errors are thrown during build. How should these be handled?

@demurgos
Copy link
Contributor

demurgos commented Jan 2, 2018

This is tracked with this gulp-tslint issue and this gulp-util issue.

Instead of ansi-*, it's better to use chalk which bundles type definitions. Type definitions for plugin-error got merged recently. Thank you for your help, but as stated in the issue, there is already a PR ready to be made, we're just waiting for the next version of plugin-error to be released: it should come soon.

A patch was submitted for vinyl-fs to keep the current version of gulp-util working with Gulp 4 so this is less urgent.

Besides, it's better to fix the issues one by one: I don't think this PR should upgrade to Gulp 4 (it's better to have a separate PR).

@panuhorsmalahti
Copy link
Owner

Agree with @demurgos

index.ts Outdated

if (level === "error") {
gutil.log(prefix, gutil.colors.red("error"), message);
fancyLog(prefix, red("error"), message);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should use fancyLog.error ?

@idleberg
Copy link
Author

@gucong3000 As far as I understand, #6 already takes care of all necessary changes. Anyway, since my fork was still lying around I made the adjustments, should anybody still want them.

demurgos added a commit to demurgos/gulp-tslint that referenced this pull request Jan 14, 2018
@demurgos
Copy link
Contributor

demurgos commented Jan 14, 2018

@idleberg
I don't see the relation with #6, is it a typo? The changes were discussed in #140 but blocked by plugin-error. They just released their new version so it allowed #143 to be submitted (it should supersede this PR).

Side note: I still think that the Gulp 4 update is outside of the scope of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants