-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gutil dependency #142
Conversation
This is tracked with this Instead of A patch was submitted for Besides, it's better to fix the issues one by one: I don't think this PR should upgrade to Gulp 4 (it's better to have a separate PR). |
Agree with @demurgos |
index.ts
Outdated
|
||
if (level === "error") { | ||
gutil.log(prefix, gutil.colors.red("error"), message); | ||
fancyLog(prefix, red("error"), message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use fancyLog.error
?
@gucong3000 As far as I understand, #6 already takes care of all necessary changes. Anyway, since my fork was still lying around I made the adjustments, should anybody still want them. |
- Closes panuhorsmalahti#141 - Closes panuhorsmalahti#142
@idleberg Side note: I still think that the Gulp 4 update is outside of the scope of this PR. |
As advised by the Gulp maintainers, this PR removes the dependency on
gulp-util
. However, since there are no type declarations for two of the replacement modules, errors are thrown during build. How should these be handled?