Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add convertStringExpiresInToNumber function for providers whose response's expires_in is a string instead of an integer(number) #112

Closed
wants to merge 1 commit into from

Conversation

hotsixman
Copy link

Some providers(like Naver) do not adhere to OAuth 2.0 specs, its response's "expires_in" is not an integer but an string(not 3600 but "3600").
If a response(json) has "expires_in" and its type is string, this function will convert it to a number.

…esponse's expires_in is a string instead of an integer(number)
@hotsixman hotsixman closed this Feb 18, 2024
@panva
Copy link
Owner

panva commented Feb 18, 2024

#77 (comment)

There's already been PRs/issues open for this. expires_in in JSON responses is defined as a number, please reach out to your provider to get a fix on their end instead, or workaround the provider issue by instantiating a Response object with the original Response properties and the body type fixed.

Repository owner deleted a comment from jacobhjkim Jun 3, 2024
Repository owner deleted a comment from hotsixman Jun 3, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2024
panva added a commit that referenced this pull request Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants