fix: Validate 'expires_in' as a convertible number #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to enhance the flexibility of the processGenericAccessTokenResponse function by allowing the expires_in field to be a string that can be converted to a positive number.
Background
In most cases, the OAuth 2.0 specification suggests that the expires_in field should be a numeric value. However, some OAuth providers deviate from this and send expires_in as a string. This creates compatibility issues when integrating with such services.
Changes
The proposed change is a minimal alteration to the existing conditional check for expires_in. It now uses Number and isNaN to validate that expires_in can be converted to a positive number, whether it comes as a string or a number.
Benefits
Enhances compatibility with OAuth providers that send expires_in as a string.
Maintains the original check for expires_in being a positive number.
Provides a more flexible and forgiving user experience.
Testing
The change is minimal and does not introduce new dependencies or require new tests. Existing tests should suffice to validate this change.
Thank you