-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For Android browsers, browserponies should not run. #4
Comments
I suggest also checking the screen resolution (if that is possible and does not just return the size of the window), if it is too small the user is probably on a mobile device. |
I believe that specifically getting pixel width and pixel height of the window itself should be satisfactory, though, if someone is loading the scripts within a small window on their system too, then this should not load, in order to actually allow the use of the site without the browser ponies getting in the way. |
Sure, but if you have a large screen you could temporarly make it larger and turn it of. I do not have an opinion on whether to automatically disable it on small windows on large screens. |
On Android i use Firefox, Browser Ponies works well |
Added: * Adagio Dazzle * Aria Blaze * Aunt Orange * Biff * Bittersweet * Button Mash * Cloakseller * Cranky * Doctor Horse * Double Diamond * Dumb-Bell * Flutterbat * Gizmo * Goldie Delicious * Grampa Gruff * Greta * Gustysnows * Henchpony #1 * Henchpony panzi#2 * Henchpony panzi#3 * Henchpony panzi#4 * Henchpony panzi#5 * Hoops * Laid-back Mule * Leadwing * Lily Longsocks * Limestone Pie * Marble Pie * Matilda * Maud Pie * Maud Pie (Filly) * Moondancer * Moonlight Raven * Neon Lights * Nerdy Delegate * Night Glider * Night Light * Parcel Post * Party Favor * Quiet Gestures * Rainbow Blaze * Rogue * Score * Silver Shill * Smooze * Sonata Dusk * Starlight Glimmer * Stormy Flare * Sugar Belle * Sunshine Smiles * Svengallop * Tealove * Toe-Tapper * Torch Song * Tree Hugger * Trouble Shoes * Truffle Shuffle * Whoa Nelly * Withers * Written Script * Zipporwhill * Zipporwhill's Father Renames: * Blinkie Pie -> Limestone Pie (Filly) * Colgate -> Minuette * Inky Pie -> Marble Pie (Filly)
As has been witnessed by myself on several different instances, there is a problem where browserponies is executed on Android and low-resource mobile devices.
Android phones and some tablets do not have the system resources to properly load or render Browser Ponies.
To that end, the code should check the user-agent string, and if the user agent string contains "Android" it should automatically unload the browserponies scripts from memory and not attempt to run.
The below code can be used to get the user agent string.
From this, the scripts should then scan the string for "Android" and on a find of that, prevent the scripts from loading. This will prevent low-resource Android devices from loading browserponies and will prevent device lockups which require a complete power down (through battery removal or otherwise) to resolve the lockup.
The text was updated successfully, but these errors were encountered: