-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library doesn't work (crashes) in newer versions of react #49
Comments
Do we know what version it last ran at? I've run into this issue as well but downgrading didn't seem to have any effect. |
I have this issue with the latest of React and NextJS too |
Any updates on this problem? |
Also would love for an update here. We really like the library but it blocks us from upgrading to react 17 |
Created a quick fix:
Seems to working fine, tests are succeeding. Will try to create a PR here later. |
I tried your fork with quick fix, everything worked pretty well until I wanted to add more items or remove some of them. So basically when children array changes Muuri Component doesn't update as intended. For example, I have an array with 9 items. I add another item to array. Now children array contains 10 components, but MuuriComponent has only 9 Muuri Items. The new child is rendered, but styles are not applied and its not registered in Muuri grid. I found a workaround for this by updating MuuriComponent key prop so it forces re-render, but it looks really bad with all that flickering and layout jumping. Any ideas how to fix this? Anyway, thank you for your help! |
Opened a PR for this. |
Cool, forgot to create a PR 😅 Hope this can be merged soon! |
Hey, any progress on this issue. I patched my react 17 instance successfully via patch-package and the linked PR |
Hello everyone, unfortunately muuri-react has not been updated for several years and there has been no community action, the muuri-react example no longer works on the latest version of React, so I have rebuilt a library muuri for react that does not depend on any version of React or muuri, depending on the version of your project depending on the version of If you want to run muuri in React 17 or React 18, you can try this library Happy coding! |
same issue |
This happens when running every example in the "showcase" pages using these versions:
muuri: 0.9.3
react: 17.0.1
react-dom: 17.0.1
muuri-react: 3.1.6
The text was updated successfully, but these errors were encountered: