Event Grid Explorer - Adding Support for Event Grid V2 #737

t-wangamy · 2023-08-16T23:51:10Z

For my Summer 2023 internship project under the Azure Messaging Event Grid team, I developed the Event Grid Explorer. This is a tool integrated in Service Bus Explorer for viewing and managing Event Grid V2 entities, including namespaces, topics and subscriptions, as well as provide create/delete operations for topics and subscriptions, publish/receive operations for events, and acknowledge/release/reject operations for events.

Currently, the Event Grid Explorer features the functionality that is available for the preview version of Event Grid V2.
This additional support for Event Grid V2 enables users to test event delivery with ease, contributing to the adoption of the new service.

The modifications include creating new Controls and Forms under ServiceBusExplorer as well as implementing an EventGridExplorerLibrary to interact with the Event Grid V2 SDK functions. This library also contains additional files under the Management folder that set up Event Grid related objects.

… Explorer Implemented Event Grid V2 library and components to view and manage Event Grid V2 entities

…plorer into EventGridExplorer

Updated Event Grid Explorer README

SeanFeldman

Excellent job, @t-wangamy.
I left a few comments, change requests, and questions.

EventGridExplorer_README.md

src/EventGridExplorerLibrary/.pkgrefgen/EventGridExplorer.csproj.nuget.dgspec.json

src/EventGridExplorerLibrary/.pkgrefgen/EventGridExplorer.csproj.nuget.g.props

src/EventGridExplorerLibrary/EventGridLibrary.cs

src/EventGridExplorerLibrary/Management/EventGridManagementClient.cs

src/EventGridExplorerLibrary/Management/Models/DeliveryConfiguration.cs

Made various fixes, including updating the connect form

SeanFeldman

Almost there. A few comments where missed out.

src/EventGridExplorerLibrary/EventGridLibrary.cs

EventGridExplorer_README.md

src/EventGridExplorerLibrary/EventGridLibrary.cs

src/EventGridExplorerLibrary/Management/Models/DeliveryConfiguration.cs

Updated EventGridExplorer README and removed Service Bus root node menu strip from Event Grid root node

…/ServiceBusExplorer into EventGridExplorer

t-wangamy · 2023-08-18T23:33:18Z

@SeanFeldman Today is actually the last day of my internship so I pushed the last changes for the Event Grid Explorer README. Thank you for reviewing my work and for your helpful feedback! I think from here my team will help with making any additional changes

SeanFeldman · 2023-08-19T00:59:36Z

@SeanFeldman Today is actually the last day of my internship so I pushed the last changes for the Event Grid Explorer README. Thank you for reviewing my work and for your helpful feedback! I think from here my team will help with making any additional changes

@t-wangamy, thank you so much for the contribution. I'll work on bringing it to the merge point. Please let me know who can continue from your team. Maybe tag them here.

Thank you and good luck!

hillaryc · 2023-08-22T21:17:32Z

@SeanFeldman Today is actually the last day of my internship so I pushed the last changes for the Event Grid Explorer README. Thank you for reviewing my work and for your helpful feedback! I think from here my team will help with making any additional changes

@t-wangamy, thank you so much for the contribution. I'll work on bringing it to the merge point. Please let me know who can continue from your team. Maybe tag them here.

Thank you and good luck!

Hi @SeanFeldman, I will continue.

SeanFeldman · 2023-09-01T14:41:14Z

@hillaryc, great!

would you be able to review the two remaining questions? Thank you.

SeanFeldman

A few clarifications, @hillaryc

src/EventGridExplorerLibrary/EventGridLibrary.cs

SeanFeldman · 2023-09-22T15:26:10Z

@hillaryc, would you be able to assist with the questions/clarifications? I'd like to wrap up the PR. Thank you for your help.

hillaryc · 2023-09-22T19:27:32Z

Yes, I will work on this today. 😊 Best Regards, Hillary From: Sean Feldman ***@***.***> Sent: Friday, September 22, 2023 8:26 AM To: paolosalvatori/ServiceBusExplorer ***@***.***> Cc: Hillary Caituiro Monge ***@***.***>; Mention ***@***.***> Subject: Re: [paolosalvatori/ServiceBusExplorer] Event Grid Explorer - Adding Support for Event Grid V2 (PR #737) @hillaryc<https://github.com/hillaryc>, would you be able to assist with the questions/clarifications? I'd like to wrap up the PR. Thank you for your help. — Reply to this email directly, view it on GitHub<#737 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AT3VM5QA4PB43M5AUAFPOP3X3WUZZANCNFSM6AAAAAA3THR3GQ>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

SeanFeldman · 2023-09-27T16:39:34Z

Yes, I will work on this today. 😊

Thank you, @hillaryc.

hillaryc · 2023-09-28T22:49:35Z

I believe I replied all questions :) Let me know if anything. @SeanFeldman

hillaryc · 2023-10-09T15:18:24Z

Hi @SeanFeldman, let me know if there is anything pending to be done to merge this.

SeanFeldman · 2023-10-10T05:01:23Z

@hillaryc, code-wise, except for the lack of information on how to regenerate the auto-generated code, the rest is OK. These are the issues I've run into while manually testing the branch.

API version - there's no default and no dynamic selector to allow users to choose from something. I suggest putting a default. I've used 2023-06-01-preview.
Multi-tenant users - I have multiple tenants and subscriptions. There's no way to indicate what tenant should be used. I've failed to log into the subscription I've provided the information for in the login/credentials screen.

Error message (redacted)

Exception: The access token is from the wrong issuer 'https://sts.windows.net/xxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx/'. It must match the tenant 'https://sts.windows.net/yyyyyy-yyyy-yyyy-yyyy-yyyyyyyyyy/' associated with this subscription. Please use the authority (URL) 'https://login.windows.net/yyyyyy-yyyy-yyyy-yyyy-yyyyyyyyyy' to get the token. Note, if the subscription is transferred to another tenant there is no impact to the services, but information about new tenant could take time to propagate (up to an hour). If you just transferred your subscription and see this error message, please try back later.

The last issue is a blocker. Since there's no simple connection string and the only way to connect is to provide resource group, subscription ID, and the EG namespace (in addition to the API version), it's unclear how to troubleshoot the connectivity when an error such as this is encountered.

src/EventGridExplorerLibrary/EventGridLibrary.cs

SeanFeldman · 2023-11-09T17:38:42Z

Status update

The PR is returning to a draft mode to address usability and maintainability.
In addition to that, there will be an effort to transition off auto-generated code to the Azure SDK and the ability to add/alter subscription filters, which is essential for working with EG v2.

* Updated UI according to review. * Set default and cancel buttons. Changed window looks. * Changed the retry timout parsing

src/EventGridExplorerLibrary/EventGridLibrary.cs

…pting values

SeanFeldman · 2024-05-27T04:37:17Z

src/Common/Helpers/EventGridException.cs

+
+namespace ServiceBusExplorer.Helpers
+{
+    public class EventGridException : Exception


Question - what does this custom exception type bring that is not handled by Exception?

I had to make this custom exception so I can throw them without having to hit the client and have the client throw the exception.

~~I must have missed that use. Could you point to where it's used? Thanks.~~

Found it here. That use is on the form. When an exception is thrown, the form logs it and swallows the exception. But with EventGrid, you're going to throw? Could you help me understand why it would need to be re-thrown?

My idea for the user experience is that I can check the format of the filter key, operator and value and verify them without depending on the armclient to do the verification.
Yes, the form will log the error, but it will still go ahead and still hit the client.

I might be missing something and would love to meet today to resolve it if possible.

I might be missing something and would love to meet today to resolve it if possible.

Let's continue the discussion at the method level comments, no need for a meeting 🙂

src/EventGridExplorerLibrary/Management/EventGridFilterValues.cs

src/ServiceBusExplorer/ServiceBusExplorer.csproj

src/EventGridExplorerLibrary/Management/Clients/EventGridControlPlaneClient.cs

ErikMogensen

Please make sure it builds without errors and warnings.

src/Common/Common.csproj

src/EventGridExplorerLibrary/EventGridExplorerLibrary.csproj

src/ServiceBusExplorer/Forms/CreateEventGridSubscriptionForm.cs

…/ServiceBusExplorer into EventGridExplorer

src/ServiceBusExplorer/Forms/CreateEventGridSubscriptionForm.cs

src/EventGridExplorerLibrary/Management/Clients/EventGridControlPlaneClient.cs

SeanFeldman

Much better, @harrieoriowo 🙂
Let me know when you're done-done (out of draft) and I'll give it a final review.

harrieoriowo · 2024-05-30T22:04:58Z

I believe I am done-done. I have opened it for final review!

resolved

SeanFeldman

Nullable reference type warnings - either don't use it or apply on the file level. Please don't turn it off at the line-by-line level.

src/ServiceBusExplorer/Forms/CreateEventGridTopicForm.cs

src/ServiceBusExplorer/Forms/PublishEventForm.cs

src/ServiceBusExplorer/Forms/ReceiveEventForm.cs

SeanFeldman · 2024-06-08T18:39:40Z

@harrieoriowo, overall, looks good. Once you're done with the last review comments, I'm 👍 to merge. Thank you.

t-wangamy added 4 commits August 16, 2023 14:18

Event Grid Explorer - Adding support for Event Grid V2 in Service Bus…

f87a0d9

… Explorer Implemented Event Grid V2 library and components to view and manage Event Grid V2 entities

Merge branch 'main' of https://github.com/paolosalvatori/ServiceBusEx…

cdd396b

…plorer into EventGridExplorer

Event Grid Explorer

e8e6791

Updated Event Grid Explorer README

Event Grid Explorer

b11b0c1

Updated Event Grid Explorer README

t-wangamy requested review from paolosalvatori, SeanFeldman and ErikMogensen as code owners August 16, 2023 23:51

SeanFeldman requested changes Aug 17, 2023

View reviewed changes

Event Grid Explorer

f0ad8fe

Made various fixes, including updating the connect form

t-wangamy requested a review from SeanFeldman August 18, 2023 04:49

Wording

afe8a98

SeanFeldman requested changes Aug 18, 2023

View reviewed changes

t-wangamy added 2 commits August 18, 2023 14:24

Event Grid Explorer

38d75ec

Updated EventGridExplorer README and removed Service Bus root node menu strip from Event Grid root node

Merge branch 'EventGridExplorer' of https://github.com/paolosalvatori…

e5b1c2a

…/ServiceBusExplorer into EventGridExplorer

t-wangamy requested a review from SeanFeldman August 18, 2023 21:58

SeanFeldman self-assigned this Sep 1, 2023

SeanFeldman added the Feature label Sep 1, 2023

SeanFeldman reviewed Sep 7, 2023

View reviewed changes

SeanFeldman reviewed Oct 10, 2023

View reviewed changes

src/EventGridExplorerLibrary/EventGridLibrary.cs Outdated Show resolved Hide resolved

Adhare to the license in the repo

7a7c463

SeanFeldman mentioned this pull request Nov 9, 2023

Change the icons in the tree view to use official icons #749

Open

ErikMogensen and others added 5 commits November 20, 2023 08:46

Improve UI event grid explorer (#752)

8207abc

* Updated UI according to review. * Set default and cancel buttons. Changed window looks. * Changed the retry timout parsing

Using Control plane sdk instead of generated files

fd86d19

Finishing up the sdks

764e8cb

Adding Filter UI

2797407

Allowing multiple filters

a366114

SeanFeldman reviewed May 22, 2024

View reviewed changes

src/EventGridExplorerLibrary/EventGridLibrary.cs Outdated Show resolved Hide resolved

src/EventGridExplorerLibrary/EventGridLibrary.cs Outdated Show resolved Hide resolved

harrieoriowo and others added 2 commits May 24, 2024 17:48

Refining the explorer with proper error handling and the filters acce…

b7c3f54

…pting values

Merge branch 'main' into EventGridExplorer

e143794

SeanFeldman requested changes May 27, 2024

View reviewed changes

ErikMogensen previously requested changes May 27, 2024

View reviewed changes

src/Common/Common.csproj Outdated Show resolved Hide resolved

src/EventGridExplorerLibrary/EventGridExplorerLibrary.csproj Outdated Show resolved Hide resolved

src/EventGridExplorerLibrary/EventGridExplorerLibrary.csproj Outdated Show resolved Hide resolved

SeanFeldman reviewed May 29, 2024

View reviewed changes

src/ServiceBusExplorer/Forms/CreateEventGridSubscriptionForm.cs Outdated Show resolved Hide resolved

harrieoriowo added 2 commits May 29, 2024 13:17

Resolving comments

1d43822

Merge branch 'EventGridExplorer' of https://github.com/paolosalvatori…

f1ed2e4

…/ServiceBusExplorer into EventGridExplorer

ErikMogensen reviewed May 29, 2024

View reviewed changes

src/ServiceBusExplorer/Forms/CreateEventGridSubscriptionForm.cs Outdated Show resolved Hide resolved

Resolving comments

46113e7

SeanFeldman previously requested changes May 30, 2024

View reviewed changes

src/EventGridExplorerLibrary/Management/Clients/EventGridControlPlaneClient.cs Outdated Show resolved Hide resolved

src/EventGridExplorerLibrary/Management/Clients/EventGridControlPlaneClient.cs Outdated Show resolved Hide resolved

Removing custom exception and moving logic into filterfactory

274791e

SeanFeldman reviewed May 30, 2024

View reviewed changes

harrieoriowo marked this pull request as ready for review May 30, 2024 22:02

Handling build warnings

b45d3d5

SeanFeldman requested changes Jun 8, 2024

View reviewed changes

src/ServiceBusExplorer/Forms/CreateEventGridTopicForm.cs Outdated Show resolved Hide resolved

src/ServiceBusExplorer/Forms/PublishEventForm.cs Outdated Show resolved Hide resolved

src/ServiceBusExplorer/Forms/ReceiveEventForm.cs Outdated Show resolved Hide resolved

Build warnings resolved

59b24b9

SeanFeldman approved these changes Jun 10, 2024

View reviewed changes

ErikMogensen merged commit 95c7742 into main Jun 10, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event Grid Explorer - Adding Support for Event Grid V2 #737

Event Grid Explorer - Adding Support for Event Grid V2 #737

t-wangamy commented Aug 16, 2023 •

edited by SeanFeldman

Loading

SeanFeldman left a comment

SeanFeldman left a comment

t-wangamy commented Aug 18, 2023

SeanFeldman commented Aug 19, 2023

hillaryc commented Aug 22, 2023

SeanFeldman commented Sep 1, 2023

SeanFeldman left a comment

SeanFeldman commented Sep 22, 2023

hillaryc commented Sep 22, 2023 via email

SeanFeldman commented Sep 27, 2023

hillaryc commented Sep 28, 2023 •

edited

Loading

hillaryc commented Oct 9, 2023

SeanFeldman commented Oct 10, 2023

SeanFeldman commented Nov 9, 2023

SeanFeldman May 27, 2024

harrieoriowo May 29, 2024

SeanFeldman May 29, 2024 •

edited

Loading

SeanFeldman May 29, 2024

harrieoriowo May 29, 2024

harrieoriowo May 29, 2024

SeanFeldman May 30, 2024

ErikMogensen left a comment

SeanFeldman left a comment •

edited

Loading

harrieoriowo commented May 30, 2024

SeanFeldman left a comment

SeanFeldman commented Jun 8, 2024

Event Grid Explorer - Adding Support for Event Grid V2 #737

Event Grid Explorer - Adding Support for Event Grid V2 #737

Conversation

t-wangamy commented Aug 16, 2023 • edited by SeanFeldman Loading

SeanFeldman left a comment

Choose a reason for hiding this comment

SeanFeldman left a comment

Choose a reason for hiding this comment

t-wangamy commented Aug 18, 2023

SeanFeldman commented Aug 19, 2023

hillaryc commented Aug 22, 2023

SeanFeldman commented Sep 1, 2023

SeanFeldman left a comment

Choose a reason for hiding this comment

SeanFeldman commented Sep 22, 2023

hillaryc commented Sep 22, 2023 via email

SeanFeldman commented Sep 27, 2023

hillaryc commented Sep 28, 2023 • edited Loading

hillaryc commented Oct 9, 2023

SeanFeldman commented Oct 10, 2023

SeanFeldman commented Nov 9, 2023

SeanFeldman May 27, 2024

Choose a reason for hiding this comment

harrieoriowo May 29, 2024

Choose a reason for hiding this comment

SeanFeldman May 29, 2024 • edited Loading

Choose a reason for hiding this comment

SeanFeldman May 29, 2024

Choose a reason for hiding this comment

harrieoriowo May 29, 2024

Choose a reason for hiding this comment

harrieoriowo May 29, 2024

Choose a reason for hiding this comment

SeanFeldman May 30, 2024

Choose a reason for hiding this comment

ErikMogensen left a comment

Choose a reason for hiding this comment

SeanFeldman left a comment • edited Loading

Choose a reason for hiding this comment

harrieoriowo commented May 30, 2024

SeanFeldman left a comment

Choose a reason for hiding this comment

SeanFeldman commented Jun 8, 2024

t-wangamy commented Aug 16, 2023 •

edited by SeanFeldman

Loading

hillaryc commented Sep 28, 2023 •

edited

Loading

SeanFeldman May 29, 2024 •

edited

Loading

SeanFeldman left a comment •

edited

Loading