Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CMakeLists a little #49

Closed
wants to merge 5 commits into from

Conversation

redstrate
Copy link
Contributor

Hello! I use this project as a git submodule (and add it via add_subdirectory) and it doesn't quite work as I expected. Making it work is super simple though:

  • Added the target_include_directories function so it's usable if you link it via target_link_libraries(myapp PRIVATE cotp)
  • Used the target_X versions of the functions like link_options, so it doesn't pollute everything around it. This might have broken tests though, I need to check.
  • Removes the explicit SHARED so it listens to BUILD_SHARED_LIBS which is a standard CMake variable. It's also added as an explicit option, and turned on by default. It's still possible to override this, which I do.
  • Adds an option for building tests, but it's on by default.

@paolostivanin
Copy link
Owner

closing as there was no further feedback

@paolostivanin paolostivanin mentioned this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants