Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl support #52

Closed
wants to merge 4 commits into from

Conversation

mchalain
Copy link

Hello,
Here my support for openssl into libcotp. I need it to embed only one hmac library on my system.
Best regards,
Marc.

This pullrequest contains:

  • a wrapper around all hmac function
  • a wrapper for libgcrypt
  • a wrapper for libcrypto (openssl 3.0.0)
    Modifications:
  • the hmac context is a dynamic pointer.
  • this same pointer creation move into a function call up and free at the same level.
  • the dlen getter function needs the context pointer.
  • the MD5 macro is defined into the test file.
    API modifications
  • none
    Testing:
  • all tests from test_cotp pass for gcrypt and openssl.

mchalain added 4 commits November 15, 2023 14:25
This is neccessary for future development of whmac_openssl.c
The new place of the whmac_gethandle allows to allocate memory only
once.
@paolostivanin
Copy link
Owner

Hello,
thanks a lot for your work! I'll review it in a few days :)

@paolostivanin
Copy link
Owner

paolostivanin commented Nov 17, 2023

@mchalain could you please rebase and make a single commit? Also, could you please sign the commit too? thanks!

@paolostivanin
Copy link
Owner

@mchalain ping

@mchalain
Copy link
Author

Ok to rebase. I will try to sign.

@paolostivanin
Copy link
Owner

I took care of that stuff with #56 , thanks a lot for your work, really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants