Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed schematic and silkscreen analog1/2 labels and LED labels #10

Closed
wants to merge 1 commit into from

Conversation

scdwyer
Copy link
Contributor

@scdwyer scdwyer commented May 7, 2012

  • switched analog1 and analog2 connector labels on schematic and silkscreen
  • changed LED labels on schematic to be more intuitive and match software defines
  • changed power led to LEDVIN from LED4 (can't be controlled) in schematic
  • changed LED silkscreen label numbers to match new schematic labels

…kscreen

 - changed LED labels on schematic to be more intuitive and match software defines
 - changed power led to LEDVIN from LED4 (can't be controlled) in schematic
 - changed LED silkscreen label numbers to match new schematic labels
@scdwyer
Copy link
Contributor Author

scdwyer commented May 7, 2012

Perhaps this should be done on Lisa/M v2.1? I see now the analog naming was fixed in commit d3555c8. However that commit didn't truly fix Issue #5 since even though it is better in future revisions it should be changed to be made consistent across the schematic/layout of lisa/m v1.0. I guess it depends on whether new batches of lisa/m will be called v2.0 or v2.1? I can just change the same on v2.1 instead if this is better.

This pull should fix Issue #9 as well. Perhaps the two fixes should be separated.

@esden
Copy link
Member

esden commented May 7, 2012

I agree this should be fixed. But together with a new version of the board. The 2.0 files in the repository should reflect what people have in their hands.

So I think the silkscreen and schematic changes should be done together with a bump of the board version to 2.1.

@scdwyer
Copy link
Contributor Author

scdwyer commented May 7, 2012

This will get confusing, especially since v2.0 boards are already available. Will implement this in Lisa/M v2.1.

@scdwyer scdwyer closed this May 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants