-
Notifications
You must be signed in to change notification settings - Fork 1
Add variable font metadata #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
itsdouges
wants to merge
11
commits into
initial-build
Choose a base branch
from
variable-fonts
base: initial-build
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+4,673
−3,794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed17ef1 to
6f276fb
Compare
vladmoroz
reviewed
Nov 7, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We need axes min/default/max per font, as they vary. Not sure why Google stores global min/default/max for each axis.
- We can reduce the axes registry to an object
"TAG": "Display name"precisionis nice but looks like we can drop it too since we don't have access to that with local fonts, so we'd need to implement a general-purpose heuristic to determine precision either way (font files don't carry this info)
vladmoroz
reviewed
Nov 7, 2025
Contributor
vladmoroz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also sort the axes in the font metadata same way we are going to do it in the app
Contributor
Author
|
Ok will adjust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axes.jsonwhich has variable font axes definitionsaxesto metadata.jsonsin fonts.json to include variants and axes if definedwe'll want to copy
fonts.json,axis.json, and the updatedfont-chunk.avifs into paper, here are direct links: