Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End with newline created config/initializers/paper_trail.rb #1009

Merged

Conversation

Yuki-Inoue
Copy link
Contributor

Currently, config/initializers/paper_trail.rb file created by
rails generate paper_trail:install
does not end with newline.
Such text files may result in trouble because in unix, because text files
generally should end with newline.

So, make it put newline at the end.

Currently, config/initializers/paper_trail.rb file created by
    rails generate paper_trail:install
does not end with newline.
Such text files may result in trouble because in unix text files
generally should end with newline.

So, make it put newline at the end.
@jaredbeck
Copy link
Member

Looks good. Please add an entry to the changelog under Unreleased -> Fixed. Thanks!

@Yuki-Inoue
Copy link
Contributor Author

@jaredbeck Done! Please check if it is done correctly!

@jaredbeck jaredbeck merged commit 8c26c0e into paper-trail-gem:master Nov 16, 2017
@jaredbeck
Copy link
Member

Thanks!

aried3r pushed a commit to aried3r/paper_trail that referenced this pull request Dec 14, 2020
…ail-gem#1009)

* End with newline created config/initializers/paper_trail.rb

Currently, config/initializers/paper_trail.rb file created by
    rails generate paper_trail:install
does not end with newline.
Such text files may result in trouble because in unix text files
generally should end with newline.

So, make it put newline at the end.

* Update CHANGELOG.md

* Remove None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants