[WIP] Rails 6 #1182
Merged
[WIP] Rails 6 #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredbeck
requested changes
Jan 25, 2019
paper_trail.gemspec
Outdated
| @@ -28,7 +28,7 @@ has been destroyed. | |||
| s.required_ruby_version = ">= 2.3.0" | |||
|
|
|||
| # Rails does not follow semver, makes breaking changes in minor versions. | |||
| s.add_dependency "activerecord", [">= 4.2", "< 6.0"] | |||
| s.add_dependency "activerecord", [">= 4.2", "< 7.0"] | |||
There was a problem hiding this comment.
Rails does not follow SemVer, so this should be < 6.1.
|
Hi Miklós. Nice to meet you and thanks for the contribution. 😄 |
jaredbeck
approved these changes
Jan 27, 2019
jaredbeck
added a commit
that referenced
this pull request
Jan 27, 2019
This fixes an omission that was not caught in #1182
aried3r
pushed a commit
to aried3r/paper_trail
that referenced
this pull request
Dec 14, 2020
This fixes an omission that was not caught in paper-trail-gem#1182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
Check the following boxes:
master(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.