Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format comments #582

Merged
merged 1 commit into from
Aug 3, 2015
Merged

Format comments #582

merged 1 commit into from
Aug 3, 2015

Conversation

jaredbeck
Copy link
Member

  • Wrap comments at 80 chars
  • Fix English grammar
    • Start sentances with capital letters
    • End sentances with a period
  • Use markdown for lists, e.g. method arguments

[ci skip]

- Wrap comments at 80 chars
- Fix English grammar
  - Start sentances with capital letters
  - End sentances with a period
- Use markdown for lists, e.g. method arguments

[ci skip]
@jaredbeck
Copy link
Member Author

I've got another PR that depends on these changes (#583) so I'll go ahead and merge this to avoid any conflicts. I don't think there's anything too controversial in formatting comments, but let me know if you see something you don't like and we can revert it.

jaredbeck added a commit that referenced this pull request Aug 3, 2015
@jaredbeck jaredbeck merged commit b5c2bce into master Aug 3, 2015
@jaredbeck jaredbeck deleted the formatting_comments branch August 3, 2015 23:12
@batter
Copy link
Collaborator

batter commented Aug 4, 2015

Man that's a lot of comment refactoring! Did you do that yourself or use a tool?

@jaredbeck
Copy link
Member Author

I wish there were a comprehensive tool for this. The English grammar and markdown lists were manual. For the hard wrap I use the "Wrap to Column" plugin for RubyMine.

@batter
Copy link
Collaborator

batter commented Aug 4, 2015

I'm likely to blame for a lot of the comments not being wrapped at 80 characters. I realize now that it is a convention amongst many developers, especially those who like to develop on emacs and vim with multiple panes in a single session, however, I didn't realize that until a year or two ago, and definitely blatantly went over that number generously on many occasions.

In terms of capitalization ¯\_(ツ)_/¯, it's comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants