Log errors when versions can't be created #809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #807, this PR updates
record_update
andrecord_destroy
to log a warning listing all validation errors when aVersion
instance cannot be saved. It does not updaterecord_create
since that callsVersion.create!
instead ofVersion.create
and should raise an error for any validation failures.Due to Rubocop complaining, I have also slightly refactored
has_paper_trail.rb
to fix some of the complaints. There is still a complaint about theInstanceMethods
module being too many lines, but I didn't see any easy way to reduce the line count of these changes without going too far off topic and into the weeds.