Fix ActiveRecord version check

[newtrat]

Minor change: the RAILS_GTE_5_1 version check in record_trail.rb looks wrong to me. It checks that ActiveRecord's major version is at least 5 and minor version is at least 1, but I think this check would exclude releases like 6.0 and 7.0.

I've changed the check to one that will match what I think was intended.

Thanks for your hard work on this gem; it's been working great for us so far!

[jaredbeck]

.. I think this check would exclude releases like 6.0 and 7.0.

I think you're right, thanks.

How about ::ActiveRecord.gem_version >= ::Gem::Version.new("5.1.0.beta1")?

[newtrat]

Ooh, I didn't realize that method existed! Yeah that's much nicer.

[jaredbeck]

Yeah, I think it was added in some version of rails 4. Hopefully rails 4.0, because we still try to support 4.0 (at least for a few more months).

[jaredbeck]

Please also add an entry to the changelog under unreleased -> fixed. Thanks.

[newtrat]

Hmm. Actually it looks like it wasn't added until 4.2, in this giant commit. I'm basing this on the Github history for the gem_version.rb file.

Should we stick with the manual integer comparison method, then?

[jaredbeck]

Hmm. Actually it looks like it wasn't added until 4.2, in this giant commit. I'm basing this on the Github history for the gem_version.rb file.

Should we stick with the manual integer comparison method, then?

Can we do something like:

::ActiveRecord.respond_to?(:gem_version) && 
  ::ActiveRecord.gem_version >= ::Gem::Version.new("5.1.0.beta1")

We can add a TODO comment about removing the respond_to? when we drop support for rails 4.0 (soon!).

[jaredbeck]

Merged, thanks.