Rename "shout" event to "message:created"

[reichert621]

This name is just the default event used when generating new channels in Phoenix, but let's make our event names a bit more descriptive... we already have conversation:created and conversation:updated events, so let's be consistent and add message:created in place of shout.

(Note: we'll probably need to keep "shout" around for backwards compatibility)

[kolharsam]

@reichert621 I could take a stab at this?

[reichert621]

sure @kolharsam! just wanted to note -- after looking into this a bit more, we'll want to keep the "shout" event around for backward compatibility, so basically what we want to do in this ticket is make sure both shout and message:created events are handled the same :)

[eikooc]

@reichert621 how do you want to keep the support? Both on the back-end and the front-end or how should I proceed if I want to pick this up? :)

[reichert621]

hey @eikooc! as mentioned above, let's make sure we continue supporting shout for backward compatibility, but change the frontend to use message:created

so the backend change will probably look something like

# just make "shout" an alias for "message:created" for backward compatibility
def handle_in("shout", payload, socket), 
  do: handle_in("message:created", payload, socket)

def handle_in("message:created", payload, socket) do
  # existing logic
end

...or something like that. what do you think?

[eikooc]

@reichert621 that was also what I was thinking. I just didn't know if you wanted the front-end to also be backwards-compatible such that if two installations happened to use the same database but different versions of the front-end, they would both work.

[reichert621]

hmm yeah... didn't think about that edge case 🤔 maybe for now let's just focus on the backend update and make sure both "shout" and "message:created" work the same

(this ticket has been a bit of a low priority, so no rush on this btw -- just think it would be nice to do sooner rather than later if possible)