Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to edit their customer's information #327

Closed
reichert621 opened this issue Oct 19, 2020 · 5 comments
Closed

Allow users to edit their customer's information #327

reichert621 opened this issue Oct 19, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest

Comments

@reichert621
Copy link
Collaborator

Problem
Our users should be able to edit their customers' information -- specifically their name, email, and phone number.

Users can currently view these fields, but not edit them... this is what we currently display:
Screen Shot 2020-10-18 at 9 08 36 PM

Solution
Make the "name", "email", and "phone number" fields editable.

To do this, we should:

  • Add a button to the bottom of the modal that says "Edit"
  • Move the "Close" button to the left side of the modal
  • When clicking the button, the modal should go into "edit mode"... this means that editable fields will change from text to input fields
  • When in edit mode, the "Edit" button should change into "Save" and "Cancel" buttons
  • Clicking "Save" should persist the changes, while "Cancel" should revert them (if any)
  • In order to persist changes, we will hit the update customer API endpoint
    • i.e. PUT /api/customers/${customerId}

Here's the component: https://github.com/papercups-io/papercups/blob/master/assets/src/components/customers/CustomerDetailsModal.tsx

Questions, or need help getting started?
Feel free to ask below, or ping us on Slack :)

(You can also check out our CONTRIBUTING.md)

@reichert621 reichert621 added enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest labels Oct 19, 2020
@swatikothari
Copy link

I can take this one

@reichert621
Copy link
Collaborator Author

sure @swatikothari :) I'll assign you 👍

@reichert621
Copy link
Collaborator Author

hey @swatikothari! any updates on this?

@joelazwar
Copy link
Contributor

hi, i know hacktoberfest is past but i'd still love to try this issue :)

@reichert621
Copy link
Collaborator Author

sure @joelazwar! i'll assign you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants