Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Edit Customer Functionality #372

Merged
merged 3 commits into from
Nov 13, 2020

Conversation

joelazwar
Copy link
Contributor

Description

Made additions to the Customer components to add edit functionality and updates the database. Most of the work was done in CustomerDetailsModal.tsx and CustomerTable.tsx

Issue

Issue #327

Screenshots

papercups

Checklist

  • Everything passes when running mix test
  • Ran mix format
  • No frontend compilation warnings

@reichert621
Copy link
Collaborator

@joelazwar thanks for tackling this! i'm a bit busy today but will try to review by end of day :)

@joelazwar
Copy link
Contributor Author

@reichert621 That's alright, please let me know if any changes at all are necessary! Still a bit new to the technology and frameworks so the code might be a bit messy to say the least 😂

@reichert621
Copy link
Collaborator

hey @joelazwar! thanks for helping out with this :) I wanted to clean a few things up real quick, so I just pushed up some changes -- happy to discuss further if you want 👍

@reichert621 reichert621 merged commit 382dfc3 into papercups-io:master Nov 13, 2020
@joelazwar
Copy link
Contributor Author

@reichert621 No problem, thanks for letting me contribute :) I'll go ahead and read your review changes to get some good insight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants