-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved PDF rendering, new target selectors and discussion controller #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (41 commits) fix discussion deletion, editing in margin use prefix_search and search api endpoints fix whitespace trimming make unit tests work again use jspm single file build instead of systemjs bundle split jspm.config.js in two parts update babel and typescript plugins for jspm chore(package): update gulp-connect to version 3.1.1 move templates moved into components folder move navbar-* template into component folders attempted fix for button spacing make office-map a component make document a component make navbar a component make notifications a component make <settings> a component make <subscribe> a component make <user> a component make login a component removed unused help controller ...
doesn't work properly yet due to js event issues with position: absolute
* master: (97 commits) Update template.html renamed footer -> ph-footer to avoid clash with standard <footer> tag fix refactoring issue with margin discussion tour popup rephrase search popover in tour use consistent tour stage names rename tour templates work around typescript-plugin (jspm) failure make main page a component make 'subscribed' page a component make jobs, footer components make auth-return a component move popover adjust texts adjust text and punctuation adjust z-index use p tag instead of div and adjust margin remove unused code increase z-index move links to the left X discussion(s) above/below -> X more discussion(s) ...
* master: fix margin link null dereference issue add comment add timeout fix pdf download button sync discussion id with beta.paperhive.org (for tour)
…ssion thread view
Issues that need to be addressed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
documentTextCtrl
!)DiscussionsCtrl
indocument
component coordinates REST API calls and websocket events fixes Discussion/reply updates are not live-synced in thread view #403This PR requires paperhive/paperhive-backend#153.