Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved PDF rendering, new target selectors and discussion controller #429

Merged
merged 70 commits into from
Apr 22, 2016

Conversation

andrenarchy
Copy link
Member

This PR includes the following:

This PR requires paperhive/paperhive-backend#153.

* master: (41 commits)
  fix discussion deletion, editing in margin
  use prefix_search and search api endpoints
  fix whitespace trimming
  make unit tests work again
  use jspm single file build instead of systemjs bundle
  split jspm.config.js in two parts
  update babel and typescript plugins for jspm
  chore(package): update gulp-connect to version 3.1.1
  move templates moved into components folder
  move navbar-* template into component folders
  attempted fix for button spacing
  make office-map a component
  make document a component
  make navbar a component
  make notifications a component
  make <settings> a component
  make <subscribe> a component
  make <user> a component
  make login a component
  removed unused help controller
  ...
doesn't work properly yet due to js event issues with position: absolute
* master: (97 commits)
  Update template.html
  renamed footer -> ph-footer to avoid clash with standard <footer> tag
  fix refactoring issue with margin discussion tour popup
  rephrase search popover in tour
  use consistent tour stage names
  rename tour templates
  work around typescript-plugin (jspm) failure
  make main page a component
  make 'subscribed' page a component
  make jobs, footer components
  make auth-return a component
  move popover
  adjust texts
  adjust text and punctuation
  adjust z-index
  use p tag instead of div and adjust margin
  remove unused code
  increase z-index
  move links to the left
  X discussion(s) above/below -> X more discussion(s)
  ...
* master:
  fix margin link null dereference issue
  add comment
  add timeout
  fix pdf download button
  sync discussion id with beta.paperhive.org (for tour)
@andrenarchy
Copy link
Member Author

andrenarchy commented Apr 21, 2016

Issues that need to be addressed:

  • tour broken
  • in-document links broken

@andrenarchy andrenarchy merged commit 3966a24 into master Apr 22, 2016
@andrenarchy andrenarchy deleted the pdf branch April 22, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant