Feature/esm cjs #43
Open
Feature/esm cjs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package: upgrade noch and mocha packages. test: adds test to get 100% coverage oai-pmh: remove retryMin as option to keep it to the got package
No real breaking changes. Only caveat is that imports of this module should all be normalized: either via `import` everywhere, or via `require`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add both esm & cjs builds. Run
npm run buildbefore release to generate output artifacts.Note that since this PR includes changes from https://github.com/VirtueMe/oai-pmh/, I'm marking it as draft to see if you want to update it (or unpublish it altogether, or transfer the repo). Please tell me if you're willing to maintain it.
This PR will be published on VirtueMe's fork as well.