Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop-up (modal) windows are above fullscreened windows #902

Closed
vinhor opened this issue Jul 20, 2024 · 7 comments · Fixed by #903
Closed

Pop-up (modal) windows are above fullscreened windows #902

vinhor opened this issue Jul 20, 2024 · 7 comments · Fixed by #903
Labels
bug Undesirable behavior PR READY Pull Request is ready

Comments

@vinhor
Copy link

vinhor commented Jul 20, 2024

Describe the bug
Dialog windows (e. g. Déjà Dup's backup process windows) overflow to other windows and don't hide even when you watch videos in full-screen
To Reproduce
Steps to reproduce the behavior:

  1. Open app with dialog windows (e. g. Déjà DUp, YaST software)
  2. Make the dialog window open
  3. Try to watch video in fullscreen
  4. The window won't hide

Expected behavior
The pop-up window will stay on top of the mother app and will hide when watching something in full-screen
Screenshots
Screenshot from 2024-07-20 12-21-48
System information:
Distribution: openSUSE Tumbleweed
GNOME Shell: 46.3.1
Display server: Wayland
PaperWM version: 46.13.5
Enabled extensions:

@vinhor vinhor added the bug Undesirable behavior label Jul 20, 2024
@Lythenas
Copy link
Collaborator

I think this is unfortunately just a downside of the hacks we have to do to get tiling to work.

You could try enabling "Attach Model Dialogs" in Gnome Tweaks. I would expect that this breaks some things but it might work for some cases.

@jtaala
Copy link
Collaborator

jtaala commented Jul 20, 2024

I think this is unfortunately just a downside of the hacks we have to do to get tiling to work.

You could try enabling "Attach Model Dialogs" in Gnome Tweaks. I would expect that this breaks some things but it might work for some cases.

That's correct, see README.md for settings that are managed by PaperWM due to incompatibility with the tiling model used in PaperWM:

https://github.com/paperwm/PaperWM?tab=readme-ov-file#recommended-gnome-shell-settings

Note, that enabling "Attach Modal Dialogs" won't work in PaperWM, as PaperWM will disable that setting when it's being enabled (and restore that setting to it's original state when PaperWM is disabled).

@jtaala
Copy link
Collaborator

jtaala commented Jul 20, 2024

P.S. we should probably change the README.md section header for these settings from Recommended Gnome Shell Settings to Managed Gnome Shell Settings.

@jtaala
Copy link
Collaborator

jtaala commented Jul 20, 2024

@vinhor,

Not sure there's much we can do re attach modal dialogs support - but if the issue is hiding modal dialogs in fullscreen, we could have PaperWM explicity address modal dialogs when a window goes fullscreen (e.g. hide the dialog or disable it's always on top parameter etc.).

@jtaala
Copy link
Collaborator

jtaala commented Jul 20, 2024

Actually, setting the "always on top" parameter for fullscreen windows looks like it will put it self above any other modal dialogs...

We could have PaperWM set a window to "always on top" when fullscreening it.

@jtaala
Copy link
Collaborator

jtaala commented Jul 21, 2024

All,

I've implemented a small change in PR #903 that ensures fullscreened windows will be "above" modal dialogs. Feel free to check it out and give it a try:

git fetch --all
git checkout improve-fullscreen-windows-set-always-on-top
./install.sh

then logout / login.

@jtaala
Copy link
Collaborator

jtaala commented Jul 21, 2024

P.S. I'll update this issue title re fullscreen windows above modal windows.

We can always create a feature request to re-look at supporting Attach modal dialogs (let me know is anyone if keen to give that one a go and create a PR for it!).

@jtaala jtaala changed the title Pop-up windows don't stay with their mother app Pop-up (modal) windows are above fullscreened windows Jul 21, 2024
@jtaala jtaala added the PR READY Pull Request is ready label Jul 23, 2024
@jtaala jtaala closed this as completed in 4c58c6f Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesirable behavior PR READY Pull Request is ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants