Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: move space to other monitors #825

Merged
merged 9 commits into from
Apr 15, 2024
Merged

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Apr 13, 2024

This PR resolves #824.

It adds the following:

  • keybinds (Ctrl+Alt+left/right/up/down) which moves the current workspace to a different monitor in that direction;
  • if a workspace is the last on a monitor, we fallback to swapping that space with the target monitor space;
  • informs user with notification if can't move / swap a space;
  • FIXES Second monitor doesn't have tiling/Crash #816 by creating spaces to meet a minimum (i.e. PaperWM breaks if have 2 monitors and only one space...);

@jtaala jtaala changed the base branch from release to develop April 13, 2024 08:05
@paperwm paperwm deleted a comment from github-actions bot Apr 13, 2024
@Lythenas
Copy link
Collaborator

As far as I can tell this works fine.

Are you sure you want to use these keybindings? I don't really use it that often but e.g. in gimp ctrl+alt+arrow moves the selection. I imagine in other graphical programs this does something similar. Not sure if that is a big deal.

@jtaala
Copy link
Collaborator Author

jtaala commented Apr 13, 2024

As far as I can tell this works fine.

Are you sure you want to use these keybindings? I don't really use it that often but e.g. in gimp ctrl+alt+arrow moves the selection. I imagine in other graphical programs this does something similar. Not sure if that is a big deal.

Good pickup. Yes, that would be confusing for sure (go to move selection in gimp and you move the workspace to another monitor...). Any suggestions for alternate keybinds?

I was trying to keep some relation to the swap keybinds (alt+super+...).

What about Ctrl+Super+left/right/up/down? can't do them since they clash with move window to monitor keybinds...

What about

  • Ctrl+Alt+Shift+left/right/up/down?

Dang, running out of keybinds...

avoid commonly used keybinds (in apps like Gimp etc.).
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Apr 14, 2024
@Lythenas
Copy link
Collaborator

Ctrl+Alt+Shift+left/right/up/down?

That is probably fine.

I would also be fine with not having default keybindings, but then the feature might be hard to discover.

@jtaala jtaala merged commit 033196b into develop Apr 15, 2024
@jtaala jtaala deleted the feature-move-space-to-monitor branch April 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to move a workspace to a monitor instead of swapping Second monitor doesn't have tiling/Crash
2 participants