Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warp pointer if focus window on another monitor #839

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Fix warp pointer if focus window on another monitor #839

merged 9 commits into from
Apr 26, 2024

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Apr 25, 2024 •
edited
Loading

Fixes a related issue partly described in #837.

Note that in Gnome 45+, PaperWM alt+tab does indeed switch through all windows across spaces and monitors (by default). However, an issue does occur that if we switch to (and focus) a window on another monitor via alt+tab etc., when we move the mouse focus will be pulled to the monitor that the mouse is on.

This PR fixes this by warping the mouse pointer to the new monitor if needed (along with a mouse pointer ripple effect).

This PR also now links the behaviour for showing all windows or only windows from current space in PaperWM to the Gnome Multitasking setting:

image

@github-actions github-actions bot changed the base branch from release to develop April 25, 2024 07:18
@paperwm paperwm deleted a comment from github-actions bot Apr 25, 2024
@jtaala jtaala mentioned this pull request Apr 25, 2024
Closed
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Apr 25, 2024
@jtaala jtaala requested a review from Lythenas April 25, 2024 10:43
Lythenas
Lythenas reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Lythenas Lythenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the eslint comment, the changes seem fine. But I haven't been able to test them yet.

utils.js Outdated Show resolved Hide resolved
@jtaala jtaala merged commit 8472ed6 into develop Apr 26, 2024
@jtaala jtaala deleted the fix-warp-pointer-if-focus-window-on-another-monitor branch April 26, 2024 14:39
@jtaala jtaala mentioned this pull request Apr 28, 2024
Merged
jtaala added a commit that referenced this pull request Apr 28, 2024
@jtaala
On focus_handler don't warp mouse pointer to another monitor if in ov…
cc9fb8e 
…erview. (#844)

This PR fixes a small regression caused by #839.

This stops warping a pointer to another monitor while in overview mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lythenas Lythenas Lythenas left review comments

Assignees
No one assigned
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtaala @Lythenas