Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybind for centering scratch window vertically (center horiztonally/vertically by default for scratch window) #924

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

jtaala
Copy link
Collaborator

@jtaala jtaala commented Aug 6, 2024

Fixes #912.

image

@jtaala jtaala requested a review from glupi-borna August 6, 2024 13:56
@jtaala jtaala added the merging soon Label for PRs that are planned to be merged soon (usually within the next week) label Aug 6, 2024
Copy link
Collaborator

@glupi-borna glupi-borna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work nicely! The only thing I'm noticing is that the 'center-horizontally' action now centers scratch windows on both axes. I'm not sure if that is intentional or not, but I'm not opposed to it working that way at all.

EDIT: Nvm, just saw your comment where you explained that it is intentional. Good stuff, one less keybind to remember! :)

@jtaala
Copy link
Collaborator Author

jtaala commented Aug 7, 2024

This seems to work nicely! The only thing I'm noticing is that the 'center-horizontally' action now centers scratch windows on both axes. I'm not sure if that is intentional or not, but I'm not opposed to it working that way at all.

I might change this though. It feels good but isn't quite "center horizontally" as the keybind suggests. I'll add another keybind specifically for center window (including non-tiled). Will probably leave it unmapped by default.

@jtaala jtaala merged commit 8c295be into develop Aug 7, 2024
@jtaala jtaala deleted the improve-center-window-keybinds branch August 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging soon Label for PRs that are planned to be merged soon (usually within the next week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants