Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken link, correct typos #937

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

AndrewKvalheim
Copy link
Contributor

Just trying PaperWM today—thanks!—and noticed a broken link in the readme. Then when I opened it for editing I spotted a few typos too.

@Lythenas
Copy link
Collaborator

Lythenas commented Aug 28, 2024

The changes seem fine. Thanks for creating a PR.

For the schema changes I'm not sure if you need to regenerate it when you change the summary only or if that is not needed. @jtaala do you know?

Also it seems the github check is broken :(

@Lythenas Lythenas changed the base branch from release to develop August 28, 2024 17:02
@jtaala
Copy link
Collaborator

jtaala commented Aug 28, 2024

For the schema changes I'm not sure if you need to regenerate it when you change the summary only or if that is not needed. @jtaala do you know?

Hey @Lythenas - no, not for the summary / description stuff. Binary compile is just if actual value or non-description schema properties change.

@jtaala
Copy link
Collaborator

jtaala commented Aug 28, 2024

Just trying PaperWM today—thanks!—and noticed a broken link in the readme. Then when I opened it for editing I spotted a few typos too.

Thanks @AndrewKvalheim! apparently I need a better spell-check! (which is just currently my brain...).

@jtaala
Copy link
Collaborator

jtaala commented Aug 28, 2024

I'll wrap this into the next release as well.

@jtaala jtaala merged commit de1c124 into paperwm:develop Aug 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants