+ Swing Reserve: [fixes #16] #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pappde
commented
Mar 3, 2021
pappde
commented
- fixes Player::m_swing_dice[] not being updated when a swing reserve die is used (i.e. goes from !IsUsed() to IsUsed())
- EXPL: there is a co-dependency between the m_swing_dice[] counts and the Die::IsUsed() state. See BMC_Player::OnDiceParsed(). If m_swing_dice[] is not updated, then the AI doesn't know that it needs to include that swing type in it's list of candidate SetSwing actions.
- added test input for bug
- Warnings: fixed one size_t -> INT cast warning
- Style: fixed several inconsistent if/else bracketing
- Project:
- partial work towards splitting up classes into distinct headers/source files
- headers: setup several
- source: only setup Stats.cpp
- player.cpp: renamed to drop the prefix
- fixes Player::m_swing_dice[] not being updated when a swing reserve die is used (i.e. goes from !IsUsed() to IsUsed()) - EXPL: there is a co-dependency between the m_swing_dice[] counts and the Die::IsUsed() state. See BMC_Player::OnDiceParsed(). If m_swing_dice[] is not updated, then the AI doesn't know that it needs to include that swing type in it's list of candidate SetSwing actions. - added test input for bug + Warnings: fixed one size_t -> INT cast warning + Style: fixed several inconsistent if/else bracketing + Project: - partial work towards splitting up classes into distinct headers/source files - headers: setup several - source: only setup Stats.cpp - player.cpp: renamed to drop the prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.