Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplicate PR builds #27

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

danlangford
Copy link
Collaborator

@danlangford danlangford commented Sep 30, 2022

I noticed with the last PR each set of builds happened twice. I think 1 build was for the PR and 1 build was for the fact that code was pushed to a branch. thats a lot of builds.

  • this PR pairs the number of builds back a little bit

  • this also incorporates the dependabots suggested changes from Bump actions/checkout from 2 to 3 #26 to increase some version numbers. ill go close that PR

  • this also adds 'Release' or 'Debug' to the name of the build artifact download

dependabot bot and others added 2 commits September 29, 2022 19:12
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@danlangford danlangford marked this pull request as ready for review September 30, 2022 01:26
@danlangford
Copy link
Collaborator Author

sorry for the spam @hamstercrack
this is just another little quality of life polish
I know I could just do this on my own fork but I dont like being out of sync with upstream and I thought "why not share these improvements back"?

@pappde pappde merged commit bbd2e01 into pappde:main Sep 30, 2022
@danlangford danlangford deleted the reduce-duplicate-pr-builds branch September 30, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants