-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cave & Cliffs Update: Part 1 support #77
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only render tip texture. Centered. Orientation fixed.
Will only render top and bottom facing texture. TODO transform base texture and place for side facing lichen.
Will only render top and bottom facing texture. TODO transform base texture and place for side facing lichen.
bennydiamond
added a commit
that referenced
this pull request
Jun 26, 2021
* Include updated block textures from pack * Add in missing textures * Re-use tripwire hook render correct method for lightning rod * Fix lightning rod placement & added more Transparent blocks * Do not use TripWire render method * Render dripstone Only render tip texture. Centered. Orientation fixed. * Fix render glow lichen Will only render top and bottom facing texture. TODO transform base texture and place for side facing lichen. * Fix lightning rod render top/bottom orientation * Fix render glow item frame Will only render top and bottom facing texture. TODO transform base texture and place for side facing lichen. * Fix wrong texture for some azalea blocks * Fix amethyst cluster render orientation * Fix amethyst buds orientation and translation * Variable for clarity * Fix small dripleaf orientation * Fix lightning rod orientation when placed sideways * Added missing "double-cut" variants texture map * Add missing rendering rules for cave vines and variants Fix for #78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to support new blocks in Cave & Cliffs Update: Part 1
Test world (rename to .mcworld for easy import, github does not allow mcworld file type):
world1.zip
Renders to the following relevant chunk:
Code is a bit of a mess but at least it's out!
Dripstone size/height is not taken into account. It will invariably render just the tip.
Glow lichen is not rendering when facing side. I don't really mind. There is a TODO comment in there if anybody wants to pick it up.
EDIT: Updated description to include cave vines