Refactor to multi-stage build and latest ruby container #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! it was on my bucket list to move my stuff to multi-stage builds.. I'll see what's going on with the gem install.. bundler can be finicky. |
|
@parabuzzle any news about this? |
|
since i am already stalking this repository: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @parabuzzle
I was experimenting around with multi stage builds in docker and I'm quite satisfied with the results of it. When using the new Dockerfile the image
uncompressedimage size of craneoperator drops from 388MB down to 124MBI'm not a really sure why I need the
bundle installin the "running"-container. If I don't put it there, in complains that some gems need to be installed first although they are all available in thevendor/folder. Maybe you can give me some input on that, since I'm not familiar with ruby/gem!?Other than that everythings seems to be working fine on my machine 🙂