Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serviceAccountTemplate from values #62

Closed
wants to merge 1 commit into from

Conversation

mdsakalu
Copy link

serviceAccountTemplate was hardcoded as an empty object - this PR updates the cluster template to use the value specified in the chart values.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@philippemnoel philippemnoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏 Good catch. CI is failing due to not having access to secrets, so will override.

@philippemnoel
Copy link

@mdsakalu Could you please sign the CLA? We need this in order to be able to merge your contribution.

@itay-grudev itay-grudev reopened this Nov 22, 2024
@philippemnoel
Copy link

I'll open a separate PR and merge since the CLa isn't signed and tests don't run. Thank you 🙏

@philippemnoel
Copy link

See #64, thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants