Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Added test for index replication #74

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

itay-grudev
Copy link
Collaborator

No description provided.

@itay-grudev itay-grudev self-assigned this Jan 2, 2025
@@ -24,7 +24,7 @@ spec:
schema_name => 'public',
table_name => 'mock_items_paradedb_enterprise'
);
CREATE INDEX search_idx_paradedb_enterprise_ ON mock_items_paradedb_enterprise
CREATE INDEX search_idx ON mock_items_paradedb_enterprise

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to stay with that name, so the index name is different from that of other tests. We only allow one BM25 index per table, and we have two tests here which each create an index on the mock_items table.

@philippemnoel
Copy link

Nice work! Thank you for doing this. This will pass once we release v0.14.0 onwards, which is what we expect. We can keep the PR open in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants