New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for views #132

Merged

philippemnoel merged 30 commits into paradedb:dev from Weijun-H:54-Support-for-views

Oct 28, 2024

Contributor

Weijun-H commented Sep 25, 2024

Ticket(s) Closed

Closes Support for views #54

What

CREATE VIEW AS SELECT ... FROM FOREIGN_TABLE do not push down to DuckDB

Why

How

In the process_utility_hook, push this view to DuckDB

Tests

test_view_foreign_table in tests/scan.rs

Weijun-H requested review from rebasedming, neilyio and philippemnoel as code owners

September 25, 2024 10:19

Weijun-H marked this pull request as draft

September 25, 2024 10:32

rebasedming reviewed

View reviewed changes

tests/scan.rs Outdated Show resolved Hide resolved

kysshsy reviewed

View reviewed changes

src/hooks/utility.rs Outdated Show resolved Hide resolved

Weijun-H marked this pull request as ready for review

September 27, 2024 03:01

Weijun-H force-pushed the 54-Support-for-views branch 3 times, most recently from fd03179 to d470794 Compare

September 27, 2024 04:39

Contributor Author

Weijun-H commented Sep 27, 2024 •

edited

Loading

---- test_view_foreign_table stdout ----
thread 'test_view_foreign_table' panicked at tests/scan.rs:615:9:
assertion `left == right` failed
  left: "error returned from database: column trips.vendorid does not exist"
 right: "WARNING: public.rate_code does not exist in DuckDB"

~~cannot reproduce the CI error on my M3 locally~~

Weijun-H force-pushed the 54-Support-for-views branch from ca5d894 to 21c9b32 Compare

September 27, 2024 05:31

Collaborator

philippemnoel commented Sep 27, 2024

---- test_view_foreign_table stdout ----
thread 'test_view_foreign_table' panicked at tests/scan.rs:615:9:
assertion `left == right` failed
  left: "error returned from database: column trips.vendorid does not exist"
 right: "WARNING: public.rate_code does not exist in DuckDB"

cannot reproduce the CI error on my M3 locally

That's strange, I would expect this kind of error to not be environment-specific.

philippemnoel force-pushed the 54-Support-for-views branch from 21c9b32 to fe20bd5 Compare

September 28, 2024 15:10

rebasedming reviewed

View reviewed changes

src/hooks/utility.rs Outdated Show resolved Hide resolved

Weijun-H force-pushed the 54-Support-for-views branch from fe20bd5 to b1f0fa5 Compare

October 1, 2024 08:38

Weijun-H mentioned this pull request

Integrate sqllogictest #144

Closed

2 tasks

Weijun-H force-pushed the 54-Support-for-views branch from 15128e0 to 2b16c9b Compare

October 2, 2024 04:08

philippemnoel reviewed

View reviewed changes

src/hooks/utility.rs Outdated Show resolved Hide resolved

philippemnoel reviewed

View reviewed changes

src/hooks/utility.rs Outdated Show resolved Hide resolved

philippemnoel reviewed

View reviewed changes

src/hooks/utility.rs Outdated Show resolved Hide resolved

philippemnoel reviewed

View reviewed changes

Collaborator

philippemnoel left a comment

This looks good to me! @kysshsy could you please help review here? If it's good with you, I'm happy to merge this.

Weijun-H force-pushed the 54-Support-for-views branch 2 times, most recently from 765eff9 to 83cc9bd Compare

October 14, 2024 12:41

kysshsy reviewed

View reviewed changes

src/hooks/utility/view.rs Outdated Show resolved Hide resolved

kysshsy reviewed

View reviewed changes

src/hooks/utility/view.rs Outdated Show resolved Hide resolved

Contributor Author

Weijun-H commented Oct 15, 2024

Thanks for your feedback @kysshsy , I will rethink this pr

Weijun-H marked this pull request as draft

October 15, 2024 13:57

Weijun-H marked this pull request as ready for review

October 16, 2024 13:03

Weijun-H force-pushed the 54-Support-for-views branch from 3239fd2 to eaa0a90 Compare

October 16, 2024 13:26

Weijun-H added 20 commits

October 27, 2024 22:17


          chore

13eb303


          chore:test

fa61a4c


          chore:test

bcefae5


          chore: Used sqlparser to parse create view statement

eef518f


          chore: Updated tests

ab1b4af


          chore: Add comments

32a8071


          chore: Add comments

918ea6c


          chore: Fix rebase

5fbf120


          chore

a2f0e67


          refactor: check pgcatalog

d323855


          chore: Fix typo

a5d8d9f


          chore: Clean up

f9bf692


          chore: Warning the table which is not a foreign table from DuckDB

834cfbd


          chore: Rebase

8248a74


          refactor: Using parse_analyze_fixedparams

01cdc6c


          refactor: Update parse_analyze_fixedparams usage in view_query function

4b69e43


          refactor: Update parse_analyze_fixedparams usage in view_query function

b6f90c3


          refactor: Update parse_analyze_fixedparams usage in view_query functi…

7e0df99

…on and use pg_analyze_and_rewrite_fixedparams instead


          fix: CI


          chore

795dc23

Weijun-H force-pushed the 54-Support-for-views branch from 80a5a5a to 795dc23 Compare

October 27, 2024 14:18

Weijun-H added 3 commits

October 27, 2024 22:32


          chore

07c46b3


          chore: Add nested test

797cd8b


          chore: Update pg_analytics

f275502

Weijun-H force-pushed the 54-Support-for-views branch from 511b8a4 to f275502 Compare

October 27, 2024 15:13


          chore

d51c7fa

Contributor

kysshsy commented Oct 27, 2024

LGTM!

kysshsy approved these changes

View reviewed changes

philippemnoel approved these changes

View reviewed changes

philippemnoel merged commit a97c8f9 into paradedb:dev

13 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kysshsy kysshsy approved these changes

philippemnoel philippemnoel approved these changes

neilyio Awaiting requested review from neilyio

rebasedming Awaiting requested review from rebasedming rebasedming is a code owner

Labels

None yet