fix: Support date_trunc
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippemnoel
changed the title
philippemnoel
added
help wanted
|
Drafting this until someone picks it up |
rebasedming
force-pushed
the
fix/arrow-date-support
branch
from
4af341b to
af8cc8f
Compare
rebasedming
changed the title
date_trunc
rebasedming
approved these changes
Aug 30, 2024
philippemnoel
added a commit
that referenced
this pull request
Sep 5, 2024
* update svg (#114) * fix: Support `date_trunc` (#95) * fixed date functions support * fixing lint & more testing * fix & remove unecessary conversion based on PR comments * date trunc test * remove unnecessary code --------- Co-authored-by: Evance Soumaoro <evanxg852000@gmail.com> Co-authored-by: Ming Ying <ming.ying.nyc@gmail.com> * fix: Json & JsonB cast support (#33) * fixed json & jsonb cast support * fixing test * fixing test * adding a better test * refactoring tests * bug fixes * json tests passing * remove debug * Increase the runner size Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com> --------- Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com> Co-authored-by: Vipul Vaibhaw <vaibhaw.vipul@gmail.com> Co-authored-by: Ming Ying <ming.ying.nyc@gmail.com> Co-authored-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com> * ci: Rm cargo clean (#116) * Rm cargo clean * Remove unnecessary test Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com> --------- Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com> * Prep v0.1.3 (#119) --------- Signed-off-by: Philippe Noël <21990816+philippemnoel@users.noreply.github.com> Co-authored-by: Ming <ming.ying.nyc@gmail.com> Co-authored-by: Evance Soumaoro <evanxg852000@gmail.com> Co-authored-by: Vipul Vaibhaw <vaibhaw.vipul@gmail.com>
philippemnoel
added a commit
that referenced
this pull request
Sep 5, 2024
* fixed date functions support * fixing lint & more testing * fix & remove unecessary conversion based on PR comments * date trunc test * remove unnecessary code --------- Co-authored-by: Evance Soumaoro <evanxg852000@gmail.com> Co-authored-by: Ming Ying <ming.ying.nyc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket(s) Closed
What
Makes
date_truncworkWhy
See Github issue
How
Added Date to Timestamp and Timestamptz conversions.
Tests
See
test_date_trunc