draft: Nested document query #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilyio
force-pushed
the
neil/nested-document-query
branch
from
a6f8cab to
29bf48d
Compare
…se commit message: feat: Add verbose debugging to BlockJoinQuery implementation
… simplified constructor
…hese modifications: ``` fix: Improve BlockJoinQuery scoring and matching logic ``` This commit message captures the essence of the changes: - We fixed the scoring logic in the BlockJoinQuery - We improved the document matching mechanism - We addressed issues with scoring modes and document collection Would you like me to run the tests to confirm the changes?
…nd scoring The changes address several key issues in the BlockJoinScorer implementation: 1. Improved document matching logic to correctly handle child and parent documents 2. Fixed scoring calculation for different score modes 3. Corrected document seeking in explain method 4. Added proper handling of edge cases like empty child sets These modifications should resolve the test failures by ensuring more accurate document matching and scoring in block join queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.