Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

feat: add AUTH instruction #14

Merged
merged 31 commits into from
Mar 20, 2024
Merged

feat: add AUTH instruction #14

merged 31 commits into from
Mar 20, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Mar 11, 2024 •
edited
Loading

Towards #5

@fgimenez fgimenez force-pushed the fgimenez/auth-authcall-instructions branch from 4ea4d73 to dc5b476 Compare March 11, 2024 17:42
@Rjected Rjected added C-enhancement New feature or request A-instruction Related to an alphanet instruction labels Mar 12, 2024
@fgimenez fgimenez force-pushed the fgimenez/auth-authcall-instructions branch from 98aabd3 to a504daa Compare March 12, 2024 11:43
@fgimenez fgimenez force-pushed the fgimenez/auth-authcall-instructions branch from dc9ce31 to 2a06a2f Compare March 14, 2024 15:30
@fgimenez fgimenez force-pushed the fgimenez/auth-authcall-instructions branch from 2a06a2f to c15b470 Compare March 14, 2024 16:08
@fgimenez fgimenez changed the title feat: add AUTH and AUTHCALL instructions feat: add AUTH instruction Mar 14, 2024
@fgimenez fgimenez marked this pull request as ready for review March 14, 2024 18:43
@fgimenez fgimenez mentioned this pull request Mar 14, 2024
Closed
Rjected
Rjected reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take a closer look tomorrow, but had one question in the meantime

crates/node/src/evm.rs Show resolved Hide resolved
mattsse
mattsse suggested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol nit and comment about context var

crates/instructions/Cargo.toml Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Show resolved Hide resolved
@fgimenez fgimenez force-pushed the fgimenez/auth-authcall-instructions branch from 993f91d to a08ef2f Compare March 15, 2024 11:10
@fgimenez fgimenez force-pushed the fgimenez/auth-authcall-instructions branch from a08ef2f to cbf1b0b Compare March 15, 2024 11:26
Rjected
Rjected suggested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice progress! I have some nits and a question about the tx nonce

crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
fgimenez and others added 4 commits March 16, 2024 11:18
@fgimenez @Rjected
Update crates/instructions/src/eip3074.rs
9f830b5 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@fgimenez @Rjected
Update crates/instructions/src/eip3074.rs
8826799 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@fgimenez
address review comments
a46af0a
@fgimenez
use array and copy_from_slice in compose_msg too
93ffa54
mattsse
mattsse reviewed Mar 16, 2024
View reviewed changes
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
crates/instructions/src/eip3074.rs Outdated Show resolved Hide resolved
Rjected
Rjected approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@Rjected Rjected requested a review from mattsse March 19, 2024 20:52
mattsse
mattsse approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,
new revm release should have a few more reexports

@fgimenez
Copy link
Member Author

new revm release should have a few more reexports

cool thx, will prepare a follow-up PR when reth is updated to use the new revm release

@fgimenez fgimenez merged commit ba7cd57 into main Mar 20, 2024
12 checks passed
@fgimenez fgimenez deleted the fgimenez/auth-authcall-instructions branch March 20, 2024 11:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

@rakita rakita Awaiting requested review from rakita

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

Assignees
No one assigned
Labels
A-instruction Related to an alphanet instruction C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgimenez @Rjected @mattsse