Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate custom-evm example #2

Merged
merged 8 commits into from
Mar 6, 2024
Merged

feat: integrate custom-evm example #2

merged 8 commits into from
Mar 6, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Mar 5, 2024 •
edited
Loading

Integrates https://github.com/paradigmxyz/reth/blob/main/examples/custom-evm/src/main.rs into the repo, I needed to make a few changes:

  • use jemallocator dep instead of tikv-jemallocator, otherwise there was an issue resolving the cc dep.
  • Use RollupArgs::default() when instantiating the components

@Rjected Rjected mentioned this pull request Mar 5, 2024
Merged
@fgimenez fgimenez changed the title WIP: feat: integrate custom-evm example feat: integrate custom-evm example Mar 6, 2024
@fgimenez fgimenez marked this pull request as ready for review March 6, 2024 10:25
@fgimenez fgimenez requested review from Rjected and mattsse March 6, 2024 10:25
mattsse
mattsse approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great start!

taking shape already

pending @Rjected

@mattsse mattsse added the C-enhancement New feature or request label Mar 6, 2024
Rjected
Rjected approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, looks good to me!

crates/node/src/lib.rs Outdated Show resolved Hide resolved
@fgimenez @Rjected
Update crates/node/src/lib.rs
09a8589 
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
@fgimenez fgimenez merged commit 8439dbb into main Mar 6, 2024
11 checks passed
@fgimenez fgimenez deleted the fgimenez/node-custom-evm branch March 6, 2024 15:14
Rjected pushed a commit that referenced this pull request Apr 22, 2024
@gakonst
Merge pull request #2 from sevasoft/patch-1
f15e77b 
Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgimenez @Rjected @mattsse