Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update seaport address #29

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mektigboy
Copy link

@mektigboy mektigboy commented Jun 29, 2023

Seaport address has been updated, ensuring the contract interacts correctly with the new Seaport version.

Copy link
Collaborator

@FrankieIsLost FrankieIsLost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, LGTM after smol nit

error NoProfit();

constructor() Owned(msg.sender) {}

Seaport constant seaport = Seaport(0x00000000000001ad428e4906aE43D8F9852d0dD6);
receive() external payable {}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid moving the receives and fallback functions to the top of the contract?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofc, np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants