Add Minimal Implementation of MEV-Share SSE Collector #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
May 5, 2023
There was a problem hiding this comment.
fyi https://github.com/mattsse/mev-share-rs
this also handles reconnects etc
|
thanks for your contribution! @mattsse's mev-share client looks good, let's please use that inside the collector instead of rolling our own 🙏 |
FrankieIsLost
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I'd get the ball rolling on this. Currently only added a collector following https://docs.flashbots.net/flashbots-mev-share/searchers/event-stream.
I imagine eventually the MEV-Share implementation will have a complementary executor with shared types, so anyone reading feel free to steal this for yourself if doing that.
Added a test as well but wasn't sure what it should test against, any ideas? Also, because MEV-Share has to send out an event before test completes, the test takes an indeterminate amount of time, sometimes ~5s waiting for a streamed event.
Related #4