Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved run.rs #197

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Improved run.rs #197

merged 2 commits into from
Nov 24, 2024

Conversation

yulesa
Copy link
Contributor

@yulesa yulesa commented Aug 23, 2024

Motivation

This PR was motivated by my attempts to understand the file. It only touches the run.rs file and tries to improve it with better structuring, more descriptive function names, and modularized code. The code behavior doesn't change with this PR.

Solution

It reduces the run function by breaking down its complex logic into smaller, well-defined, and descriptive functions, with the goal of improving readability and maintainability.

It adds .env files to gitignore, allowing users to source env. variables only in the context of the terminal.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yulesa
Copy link
Contributor Author

yulesa commented Aug 23, 2024

Split diff view makes it easier to understand the proposed changes:
image

@sslivkoff sslivkoff merged commit dbc6deb into paradigmxyz:main Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants