-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exponential backoff to queries using RetryClient #60
Conversation
looking great wdyt the defaults should be? max-retries=10 could be fine, unless that means that a broken node won't be detected for something like 2**10 * 0.5 = 512 seconds. but maybe the |
5 & 1000 (or maybe 500) seems reasonable. 10 & 500 came from the default values in the retryclient docs. Will update the defaults! |
@sslivkoff defaults updated and marking this one ready for review. will close the other one |
looks great |
This reverts commit a2941ce.
* wip trying to get error type * Add retry option to args * format * adapt to new fetcher pattern * remove debug * fix test * Try using retry client * fix * update defaults
Similar to #59 but using the default ethers retry client (looks a lot cleaner)
New provider