-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bundle diff report #63
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,106 @@ | ||
name: Bundle diff | ||
|
||
on: [pull_request] | ||
|
||
jobs: | ||
build-base: | ||
name: Build | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- name: Checkout repo | ||
uses: actions/checkout@v2 | ||
with: | ||
ref: ${{ github.base_ref }} | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 16 | ||
|
||
- name: Install dependencies | ||
uses: bahmutov/npm-install@v1 | ||
|
||
- name: Build project | ||
run: npm run build | ||
|
||
- name: Upload base stats.json | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: base | ||
path: ./dist/stats.json | ||
retention-days: 1 | ||
build-pr: | ||
name: Build PR | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
|
||
- name: Install dependencies | ||
uses: bahmutov/npm-install@v1 | ||
|
||
- name: Build project | ||
run: npm run build | ||
|
||
- name: Upload base stats.json | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: pr | ||
path: ./dist/stats.json | ||
retention-days: 1 | ||
report: | ||
name: Generate report | ||
runs-on: ubuntu-latest | ||
needs: [build-base, build-pr] | ||
|
||
steps: | ||
- name: Checkout PR | ||
uses: actions/checkout@v2 | ||
|
||
- name: Check if base artifact exists | ||
uses: xSAVIKx/artifact-exists-action@v0 | ||
id: check_artifact | ||
with: | ||
name: 'base' | ||
|
||
- name: Download base stats | ||
if: steps.check_artifact.outputs.exists == 'true' | ||
uses: actions/download-artifact@v2 | ||
with: | ||
name: base | ||
path: base | ||
|
||
- name: Download base stats | ||
if: steps.check_artifact.outputs.exists == 'true' | ||
uses: actions/download-artifact@v2 | ||
with: | ||
name: base | ||
path: base | ||
|
||
- name: Download PR stats | ||
if: steps.check_artifact.outputs.exists == 'true' | ||
uses: actions/download-artifact@v2 | ||
with: | ||
name: pr | ||
path: p | ||
|
||
- name: Get diff | ||
if: steps.check_artifact.outputs.exists == 'true' | ||
id: get-diff | ||
uses: NejcZdovc/bundle-size-diff@v1 | ||
with: | ||
base_path: './base/stats.json' | ||
pr_path: './pr/stats.json' | ||
|
||
- name: Comment | ||
if: steps.check_artifact.outputs.exists == 'true' | ||
uses: NejcZdovc/comment-pr@v1.1.1 | ||
with: | ||
file: 'comment.md' | ||
env: | ||
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} | ||
OLD: ${{steps.get-diff.outputs.base_file_string}} | ||
NEW: ${{steps.get-diff.outputs.pr_file_string}} | ||
DIFF: ${{steps.get-diff.outputs.diff_file_string}} | ||
DIFF_PERCENT: ${{steps.get-diff.outputs.percent}} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just put this all under the previous build one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed we can. But as I mentioned in the linked issue, the pipeline does not work unfortunately, since there is no tool that can gather a rollup diff.