Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store ChainId as u64 and move network names to a constant. Currently it is generated as an inline array which is computed on every function call to
get_network_names
; this shows up in Foundry release binary as one of the biggest functions (usingcargo-bloat
):Making ChainId a u64 simplifies a ton of code, I'm not sure why this was a String with conversions from/to integers in the first place rather than the opposite
This is a breaking change to the
ChainId
andget_network_names
APIs to reduce allocations, but it doesn't have to be if you feel strongly about breaking changes.Serde for ChainId is also unmodified.