fix: pin reth version, fix: backfill example #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
force-pushed
the
nico/fix/backfill
branch
from
a0d95f4 to
38bdd12
Compare
merklefruit
commented
Aug 6, 2024
backfill/Cargo.toml
Outdated
| @@ -22,7 +22,7 @@ tokio.workspace = true | |||
|
|
|||
| # rpc | |||
| async-trait = "0.1" | |||
| jsonrpsee = { version = "0.23", features = ["server", "macros"] } | |||
| jsonrpsee = { version = "0.24.2", features = ["server", "macros"] } | |||
There was a problem hiding this comment.
for some reason, there was also a version mismatch for jsonrpsee. this version bump fixes it.
zerosnacks
reviewed
Aug 7, 2024
zerosnacks
reviewed
Aug 7, 2024
Co-authored-by: zerosnacks <95942363+zerosnacks@users.noreply.github.com>
onbjerg
approved these changes
Aug 7, 2024
zerosnacks
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pins the version of Reth used across all examples.
Notably, the latest version broke the backfill example. This issue is also breaking CI in #12.